Simplify is_builder_pipeline

Author: GromNaN

psalm-baseline.xml

@@ -890,6 +890,7 @@
     <MixedAssignment>
       <code><![CDATA[$element[$key]]]></code>
       <code><![CDATA[$stage]]></code>
+      <code><![CDATA[$stage]]></code>
       <code><![CDATA[$type]]></code>
       <code><![CDATA[$typeMap['fieldPaths'][$fieldPath . '.' . $existingFieldPath]]]></code>
       <code><![CDATA[$typeMap['fieldPaths'][$fieldPath]]]></code>

src/functions.php

@@ -336,28 +336,17 @@ function is_pipeline(array|object $pipeline, bool $allowEmpty = false): bool
  */
 function is_builder_pipeline(array $pipeline): bool
 {
-    if (! $pipeline) {
+    if (! $pipeline || ! array_is_list($pipeline)) {
         return false;
     }
 
-    if (! array_is_list($pipeline)) {
-        return false;
-    }
-
-    $result = false;
     foreach ($pipeline as $stage) {
-        if (! is_array($stage) && ! is_object($stage)) {
-            return false;
-        }
-
-        if ($stage instanceof StageInterface) {
-            $result = true;
-        } elseif (! is_first_key_operator($stage)) {
-            return false;
+        if (is_object($stage) && $stage instanceof StageInterface) {
+            return true;
         }
     }
 
-    return $result;
+    return false;
 }
 
 /**

tests/FunctionsTest.php

@@ -327,7 +327,6 @@ public function provideStagePipelines(): iterable
         yield 'map of stages' => [false, [1 => new MatchStage([])]];
         yield 'stages' => [true, [new MatchStage([]), new LimitStage(1)]];
         yield 'stages and operators' => [true, [new MatchStage([]), ['$limit' => 1]]];
-        yield 'stages and invalid' => [false, [new MatchStage([]), ['foo' => 'bar']]];
     }
 
     /** @dataProvider provideWriteConcerns */