Skip to content

fix(NODE-6436): only force majority write concern on commitTransaction retry #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 17, 2024
Merged

fix(NODE-6436): only force majority write concern on commitTransaction retry #4284

merged 6 commits into from
Oct 17, 2024

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Oct 17, 2024 •
edited
Loading

Description

What is changing?

Ensure that commitTransaction only overrides the write concern when the commitTransaction call is retried (both with builtin retry mechanism and user-initiated retry).

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Needed by NODE-3914

Release Highlight

ClientSession.commitTransaction() no longer unconditionally overrides write concern

Prior to this change, ClientSession.commitTransaction() would always override any previously configured writeConcern on the initial attempt. This overriding behaviour now only applies to internal and user-initiated retries of ClientSession.commitTransaction() for a given transaction.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review October 17, 2024 16:03
@W-A-James W-A-James mentioned this pull request Oct 17, 2024
Merged
5 tasks
@durran durran self-assigned this Oct 17, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 17, 2024
durran
durran requested changes Oct 17, 2024
View reviewed changes
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 17, 2024
@durran durran merged commit a7d1d43 into main Oct 17, 2024
26 of 28 checks passed
@durran durran deleted the NODE-6436 branch October 17, 2024 21:33
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
@shafeeqd959 shafeeqd959 mentioned this pull request Nov 11, 2024
Closed
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 12, 2024
Closed
@skanda890 skanda890 mentioned this pull request Nov 12, 2024
Merged
@thnbih thnbih mentioned this pull request Nov 12, 2024
Open
This was referenced Nov 13, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@W-A-James @durran