refactor!: remove deprecated Collection.group helper #2609
Conversation
|
@emadum did you mean to request reviewers on this? |
Oops meant to make this a draft, not quite ready yet. |
test/functional/mapreduce.test.js
Outdated
| @@ -386,7 +330,7 @@ describe('MapReduce', function () { | |||
| } | |||
| }); | |||
|
|
|||
| it('shouldCorrectlyReturnNestedKeys', { | |||
| it.skip('shouldCorrectlyReturnNestedKeys', { | |||
There was a problem hiding this comment.
@mbroadst Do you think this test should be rewritten without collection.group, or is it fine to just remove it outright?
There was a problem hiding this comment.
I think it's fine to remove outright. It kind of looks like this test is testing the behavior of MongoDB, rather than some behavior of the driver itself
|
|
||
| execute(server: Server, callback: Callback<Document>): void { | ||
| const cmd: Document = { | ||
| group: { |
There was a problem hiding this comment.
This is small but: I think this file is the only place where we ever define cmd.group. If so, could we delete any leftover references to cmd.group? I remember seeing it referenced in at least one place (commandSupportsReadConcern) but there may be others.
There was a problem hiding this comment.
Good catch! I did some grepping and I think that was the last remaining reference to cmd.group.
Description
The group command was deprecated in MongoDB 3.4 and removed in
MongoDB 3.6, this PR removes it from the driver.
NODE-1487
What changed?
Are there any files to ignore?