fix(NODE-3417): allow calling db() before MongoClient is connected
#2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
db() before MongoClient is connecteddb() before MongoClient is connected
|
@nbbeeken any thoughts on merging this now that 4.0 is officially released? |
nbbeeken
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Yea LGTM!
Just for posterity:
Tracking down the origin of this error revealed that the Db class used to take the topology as the second argument to the constructor, that's no longer the case and there's no reliance on the topology existing before grabbing a Db reference.
The UX change here is when you go to run an operation the error occurs when the topology is fetched by getTopology:
Uncaught MongoDriverError: MongoClient must be connected to perform this operation
at Object.getTopology (lib/utils.js:383:11)
at Collection.insertOne (lib/collection.js:151:61)
emadum
approved these changes
Jul 15, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed an error case that will make Automattic/mongoose#8702 much easier.
What changed?
Removed a check that looks unnecessary because the
Db()constructor no longer takes atopologyparam.Are there any files to ignore?