Skip to content

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 11, 2022

Description

What is changing?

A change in the error message in server 6.0 started causing issues with tests, this syncs a change where we test against a smaller subset of the error message that is unlikely to change.

What is the motivation for this change?

FLE tests passing.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-4181/fle-test-fix branch from 39b978e to 4890a31 Compare April 11, 2022 19:22
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is in draft status but it's passing CI. LGTM

@nbbeeken nbbeeken marked this pull request as ready for review April 11, 2022 19:52
@baileympearson baileympearson merged commit 5b3d01b into main Apr 11, 2022
@baileympearson baileympearson deleted the NODE-4181/fle-test-fix branch April 11, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants