chore: fix sinon leak in tests #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/node-specific/bson-options/utf8_validation.test.ts
Outdated
Show resolved
Hide resolved
baileympearson
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
We accidentally left a sinon spy outstanding which accumulates memory for all the usages of the function. It started to cause an issue on my connect expirementation PR because failures seems to exagerrate the problem, with this change the memory usage of a test run remains constant.
What is the motivation for this change?
Quick fix to help others that might hit this.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>