Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move CountDocument logic into collection API #4138

Merged
merged 4 commits into from
Jun 10, 2024
Merged

refactor: move CountDocument logic into collection API #4138

merged 4 commits into from
Jun 10, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 7, 2024

Description

What is changing?

  • Delete CountDocument operation class
  • Move logic into collection.countDocuments
Is there new documentation needed for these changes?

What is the motivation for this change?

The subclass is unneccessary and make typing difficult. See: #4112 (comment)

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken mentioned this pull request Jun 7, 2024
Merged
5 tasks
@baileympearson baileympearson merged commit e517ab3 into NODE-6136-cursor-response Jun 10, 2024
20 of 26 checks passed
@baileympearson baileympearson deleted the chore-migrate-count-doc-operation branch June 10, 2024 16:00
nbbeeken added a commit that referenced this pull request Jun 10, 2024
@nbbeeken
Revert "refactor: move CountDocument logic into collection API (#4138)"
463657e 
This reverts commit e517ab3.
@nbbeeken nbbeeken mentioned this pull request Jun 10, 2024
Merged
@nbbeeken nbbeeken restored the chore-migrate-count-doc-operation branch June 10, 2024 17:12
@evergreen-ci-prod evergreen-ci-prod bot mentioned this pull request Jun 10, 2024
Closed
5 tasks
@nbbeeken nbbeeken deleted the chore-migrate-count-doc-operation branch June 13, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson