This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 151
Retry on SocketError when calling resolv() #265
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave a latency. For example when a node is removed and then added back later.
Added several changes to address other outstanding issues that needed to be addressed for Moped to function in our production environment |
…ew primary Fails immediately with Moped::Errors::QueryFailure: failed with error 13435: "not master and slaveOk=false"
Confirmed that the tests complete successfully on Ruby V2.1.1. Appears the above test failure is a hanging Travis environment. Can you try re-running the test? The above fixes are after thorough testing with replica-sets across multiple data centers in production. We are currently running these fixes in production and have found Moped to be significantly more stable with them. |
This was referenced Apr 18, 2014
Thanks for this. I believe this is what's causing an issue of mine. |
…ve Resolv.each_address when not required
Conflicts: lib/moped/address.rb
Replaced Mongoid with MongoMapper to remove Moped due to constant production problems with Moped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running for a few more days in production, we changed it to retry the resolv() call should it fail rather than removing the node from the list of available servers.
So far this latest change appears to be working well in our production environments.
The only issue from a generic perspective is that it is has a hard-coded retry of 3. Is there a better way to configure it in Moped?