Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add more details to apple touch events #3091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bytesandwich
Copy link

Description of Change
Set the SKTouchDeviceType more accurately for touch events on Mac or iOS.

This would be very useful to me. Does it seem like a welcome change? I'd like to discuss before working any further.

Building on Mac wasn't working in my fork, so I developed this in another maui hello world project and developed and ran it there.

This diff simply elaborates the device type based on information already in touch event.

Bugs Fixed

  • Fixes #

API Changes

This will make touch events on iOS and Mac have touch types which are more accurately one of:

SKTouchDeviceType.Mouse
SKTouchDeviceType.Pen
SKTouchDeviceType.Touch

rather than always Touch

Behavioral Changes

Same as the above API change.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • [ x] Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@bytesandwich
Copy link
Author

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant