Skip to content

inherited indexer showing up on subclass and resolve Nullableattribu… #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2020
Merged

inherited indexer showing up on subclass and resolve Nullableattribu… #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mdoc/Mono.Documentation/Updater/DynamicParserContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ namespace Mono.Documentation.Updater
public class DynamicParserContext
{
public ReadOnlyCollection<bool> TransformFlags;
public int TransformIndex;

public int TransformIndex;
public bool IsNullableAttribute;
public DynamicParserContext (ICustomAttributeProvider provider)
{
CustomAttribute da;
Expand All @@ -25,6 +25,9 @@ public DynamicParserContext (ICustomAttributeProvider provider)

TransformFlags = new ReadOnlyCollection<bool> (values.Select (t => (bool)t.Value).ToArray ());
}

IsNullableAttribute = provider.HasCustomAttributes &&
provider.CustomAttributes.Any(ca => ca.AttributeType.FullName == "System.Runtime.CompilerServices.NullableAttribute");
}
}
}
6 changes: 6 additions & 0 deletions mdoc/Mono.Documentation/Updater/Formatters/CSharpFullMemberFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ protected override string GetTypeName(TypeReference type, DynamicParserContext c
}
}

if (context != null && context.IsNullableAttribute)
{
var TypeName = base.GetTypeName(type, context, appendGeneric, useTypeProjection);
return TypeName + "?";
}

return base.GetTypeName(type, context, appendGeneric, useTypeProjection);
}

Expand Down