Added attribute formatter for C++ WINRT #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
@jeffreyxrh you should have access to the mdoc-smoke-test results ... let me know if you have any questions |
|
@jeffreyxrh - The raw Jenkins log (and smoke-test) show that the monodocer is erroring out because of the new inclusion of the raw triple slash comment. |
joelmartinez
requested changes
Jul 22, 2020
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
In general this is looking good ... just a few adjustments and it will be ready to merge :) /cc @IrinVoso
mdoc/Mono.Documentation/Updater/Formatters/AttributeFormatters/AttributeFormatter.cs
Outdated
Show resolved
Hide resolved
mdoc/Mono.Documentation/Updater/Formatters/AttributeFormatters/AttributeFormatter.cs
Outdated
Show resolved
Hide resolved
mdoc/Mono.Documentation/Updater/Formatters/AttributeFormatters/CppWinRtAttributeFormatter.cs
Outdated
Show resolved
Hide resolved
joelmartinez
requested changes
Jul 24, 2020
mdoc/Mono.Documentation/Updater/Formatters/AttributeFormatters/AttributeFormatter.cs
Outdated
Show resolved
Hide resolved
joelmartinez
requested changes
Jul 27, 2020
mdoc/Mono.Documentation/Updater/Formatters/AttributeFormatters/CppWinRtAttributeFormatter.cs
Outdated
Show resolved
Hide resolved
joelmartinez
approved these changes
Jul 28, 2020
Member
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
Thanks for all the changes! 👏
joelmartinez
pushed a commit
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.