Improve argument value formatter that fix the value of attribute argument not imported correctly #539
Conversation
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
Thanks for opening the PR ... I've made a few comments. And also looking at the build result, it seems to be failing on a strange diff; doesn't look like there's any actual change here?
In any case, please let us know when you've got this working, or otherwise if you come across any other blockers. Thanks!
mdoc/Mono.Documentation/Updater/Formatters/AttributeFormatters/AttributeValueFormatter.cs
Outdated
Show resolved
Hide resolved
hiihellox10
changed the title
…gs enum type, not apply attribute flags enum type, unknown value enum type, and add test cases for them.
|
@hiihellox10 I see the tests are passing now, which is great! Is the PR ready for review? if so, please publish it (it's currently a draft) |
…annot be correctly identified, remove some test codes, refactoring test cases and codes.
@joelmartinez the issue is closer to fixed but it is have not complete that still have a few related issues need to be resolved. |
…ibute can not be correct render, and add test cases for this.
…add test cases for this.
joelmartinez
left a comment
joelmartinez
left a comment
There was a problem hiding this comment.
Thanks for the contribution, this will really improve attribute value rendering
joelmartinez
deleted the
xiao/fix-default-value-of-attribute-not-imported-correctly
branch
When a defined property of an attribute is an object type that the value of the property cannot be correctly identified. For example, the ConfigurationPropertyAttribute.DefaultValue property is an object type so the value of the DefaultValue property can be of any type but we don't support convert the value to a correct type before. I create some test cases to reproduce and fix the issue of the same type. Now we have supported all the attribute parameter types.