Support for custom metadata field in Kubernetes auth backend config #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change accompanies monzo/vault-plugin-auth-kubernetes#1, which adds a new config flag to the Kubernetes auth plugin , which if enabled will cause the auth plugin to read service account annotations in Kubernetes prefixed with vault.hashicorp.com/auth-metadata/ as auth metadata in Vault.
|
Blocked by hashicorp/vault-plugin-auth-kubernetes#132 so doesn't look like it will be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change accompanies monzo/vault-plugin-auth-kubernetes#1, which adds a new config flag enable_custom_metadata_from_annotations to the Kubernetes auth plugin. If enabled this will cause the auth plugin to read service account annotations in Kubernetes prefixed with vault.hashicorp.com/auth-metadata/ as auth metadata in Vault.
Community Note
Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request
Relates OR Closes #0000
Release note for CHANGELOG:
resource/vault_kubernetes_auth_backend_config: Addenable_custom_metadata_from_annotationsconfig parameter to k8s auth backend (PR link TODO)data/vault_kubernetes_auth_backend_config: Addenable_custom_metadata_from_annotationsconfig parameter to k8s auth backend (PR link TODO)Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX'
TODO
...