MDL-75659 core: Don't render component argument twice in mustache pix helper

larsbonczek · Jenkins · commit 128c0c21607a · 2023-03-08T00:54:14.000Z
diff --git a/lib/classes/output/mustache_pix_helper.php b/lib/classes/output/mustache_pix_helper.php
@@ -68,7 +68,6 @@ public function pix($text, Mustache_LambdaHelper $helper) {
         if (!$component) {
             $component = '';
         }
-        $component = $helper->render($component);
         $text = strtok("");
         // Allow mustache tags in the last argument.
         $text = trim($helper->render($text));

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@ public function pix($text, Mustache_LambdaHelper $helper) {`
`68`	`68`	`if (!$component) {`
`69`	`69`	`$component = '';`
`70`	`70`	`}`
`71`		`- $component = $helper->render($component);`
`72`	`71`	`$text = strtok("");`
`73`	`72`	`// Allow mustache tags in the last argument.`
`74`	`73`	`$text = trim($helper->render($text));`