Add force-debug flag, and pallet-sudo to moonriver #2491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
commented
Sep 18, 2023
Closed
noandrea
added
B7-runtimenoteworthy
noandrea
added
the
D5-nicetohaveaudit⚠️
librelois
reviewed
Oct 6, 2023
runtime/moonriver/src/lib.rs
Outdated
| $($common_pallets)* | ||
|
|
||
| // Aditional pallets with `force-debug` feature: | ||
| // Sudo was previously index 40 |
There was a problem hiding this comment.
For safety, it would be better to use a different index. Because the sudo key storage was not removed on moonriver live storage
There was a problem hiding this comment.
Changed index to 240
notlesh
added
D1-audited👍
tmpolaczyk
changed the title
|
force-debug will be always enable and then removed: paritytech/polkadot-sdk#3005 And we finally don't want sudo on moonriver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables "evm/force-debug" feature and pallet-sudo in moonriver.
Supersedes #2490