Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose moon_getLatestSyncedBlock RPC endpoint #2858

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

gonzamontiel
Copy link
Contributor

What does it do?

  • Exposes an RPC endpoint on moon_getLatestSyncedBlock
  • Returns the latest synced block number

What important points reviewers should know?

  • I included it in the finality rpc module since it looked somehow appropriate.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

Is blocked by moonbeam-foundation/frontier#218

What value does it bring to the blockchain users?

@gonzamontiel gonzamontiel changed the title Expose RPC endpoint Expose moon_getLatestSyncedBlock RPC endpoint Jul 4, 2024
@gonzamontiel gonzamontiel added B0-silent Changes should not be mentioned in any release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 4, 2024
@gonzamontiel gonzamontiel self-assigned this Jul 4, 2024
@librelois librelois added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Coverage Report

@@                        Coverage Diff                        @@
##           master   gonza-rpc-latest-synced-block      +/-   ##
=================================================================
+ Coverage   81.10%                          81.33%   +0.23%     
+ Files         274                             301      +27     
+ Lines       80566                           85711    +5145     
=================================================================
+ Hits        65343                           69709    +4366     
+ Misses      15223                           16002     +779     
Files Changed Coverage
/client/rpc/finality/src/lib.rs 88.14% (-7.78%) 🔽
/pallets/parachain-staking/src/lib.rs 91.73% (-0.01%) 🔽
/pallets/parachain-staking/src/mock.rs 97.65% (+0.02%) 🔼
/pallets/parachain-staking/src/tests.rs 91.39% (+0.03%) 🔼
/precompiles/xcm-transactor/src/v1/mod.rs 87.95% (+0.45%) 🔼
/precompiles/xcm-transactor/src/v2/mod.rs 76.42% (-2.22%) 🔽
/precompiles/xcm-transactor/src/v3/mod.rs 83.33% (-2.26%) 🔽
/precompiles/xcm-utils/src/lib.rs 90.98% (-0.69%) 🔽

Coverage generated Wed Jul 10 09:07:35 UTC 2024

client/rpc/finality/src/lib.rs Outdated Show resolved Hide resolved
RomarQ
RomarQ previously approved these changes Jul 10, 2024
@RomarQ RomarQ added the A8-mergeoncegreen Pull request is reviewed well. label Jul 10, 2024
@gonzamontiel gonzamontiel merged commit 0cdea88 into master Jul 10, 2024
29 checks passed
@gonzamontiel gonzamontiel deleted the gonza-rpc-latest-synced-block branch July 10, 2024 09:10
@noandrea noandrea added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes and removed B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants