-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose moon_getLatestSyncedBlock RPC endpoint #2858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzamontiel
changed the title
Expose RPC endpoint
Expose moon_getLatestSyncedBlock RPC endpoint
Jul 4, 2024
gonzamontiel
added
B0-silent
Changes should not be mentioned in any release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Jul 4, 2024
librelois
added
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
not-breaking
Does not need to be mentioned in breaking changes
and removed
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Jul 4, 2024
Coverage Report@@ Coverage Diff @@
## master gonza-rpc-latest-synced-block +/- ##
=================================================================
+ Coverage 81.10% 81.33% +0.23%
+ Files 274 301 +27
+ Lines 80566 85711 +5145
=================================================================
+ Hits 65343 69709 +4366
+ Misses 15223 16002 +779
|
RomarQ
requested changes
Jul 9, 2024
RomarQ
previously approved these changes
Jul 10, 2024
RomarQ
reviewed
Jul 10, 2024
RomarQ
approved these changes
Jul 10, 2024
noandrea
added
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
and removed
B0-silent
Changes should not be mentioned in any release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
labels
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A8-mergeoncegreen
Pull request is reviewed well.
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
moon_getLatestSyncedBlock
What important points reviewers should know?
finality
rpc module since it looked somehow appropriate.Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
Is blocked by moonbeam-foundation/frontier#218
What value does it bring to the blockchain users?