Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when tokenization fails due to mistyped dataset entries. #1529

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Throw error when tokenization fails due to mistyped dataset entries. #1529

wants to merge 5 commits into from

Conversation

milocress
Copy link
Contributor

Catches tokenization failures on custom HF datasets with missing/extra/mistyped columns.

@milocress milocress requested a review from a team as a code owner September 16, 2024 22:07
irenedea
irenedea previously approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenedea
Copy link
Contributor

irenedea commented Oct 5, 2024

unit tests?

@irenedea irenedea self-requested a review October 5, 2024 00:41
@irenedea irenedea dismissed their stale review October 5, 2024 00:41

would like to see unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea Awaiting requested review from irenedea

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milocress @irenedea @dakinggg