Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird file name behaviour #6

Closed
Unaimend opened this issue Feb 15, 2023 · 9 comments
Closed

Weird file name behaviour #6

Unaimend opened this issue Feb 15, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@Unaimend
Copy link

Hello I have a really weird problem
The folder I use to create the ANI map contains those two species
image
but they are saved as
image.

As you can see the last a is missing.

@Unaimend
Copy link
Author

This also happens with other species

@Unaimend
Copy link
Author

image

image

@Unaimend
Copy link
Author

And it only happens when the species ends with an a

@Unaimend Unaimend reopened this Feb 15, 2023
@Unaimend
Copy link
Author

image
The plot is also affected

@moshi4
Copy link
Owner

moshi4 commented Feb 15, 2023

Hi, @Unaimend

Thank you for reporting the issue.

You are right, indeed, if the last character of the file is a, it is unnaturally removed due to the incorrect use of the rstrip function below.

names.append(Path(row[0]).with_suffix("").name.rstrip(".fna"))

It was my intention to remove only the .fna string, but in fact the character ending ., f, n, and a were removed.

I will try to release an fixed version by the end of today/tomorrow.

@Unaimend
Copy link
Author

Thank you very much

@moshi4
Copy link
Owner

moshi4 commented Feb 17, 2023

A new ANIclustermap v1.2.0 has been released that fixes the bugs raised in this issue.

If you are using pip, you can upgrade with pip install -U aniclustermap.
The bioconda version may be released early next week, since the release to bioconda requires some procedures such as review.

I will report back when all the release work is done.

@moshi4
Copy link
Owner

moshi4 commented Feb 18, 2023

The Bioconda team merged the release earlier than expected. All v1.2.0 release work has been completed.

ANIclustermap is now available for conda as well, so give it a try.

@moshi4 moshi4 closed this as completed Feb 20, 2023
@Unaimend
Copy link
Author

I can confirm that the big has been fixed. Again, thank you very much

@moshi4 moshi4 added the bug Something isn't working label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants