-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add in-memory lock #399
Conversation
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 59.83% 60.18% +0.35%
==========================================
Files 116 117 +1
Lines 6197 6252 +55
==========================================
+ Hits 3708 3763 +55
Misses 2128 2128
Partials 361 361
Continue to review full report at Codecov.
|
…add_in_memory_lock # Conflicts: # components/lock/in-memory/in_memory_lock.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I just fixed a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This component can make debug easier.Thanks! |
What this PR does:
add lock in memory
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?: