Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add in-memory lock #399

Merged
merged 13 commits into from
Mar 11, 2022
Merged

feat: add in-memory lock #399

merged 13 commits into from
Mar 11, 2022

Conversation

stulzq
Copy link
Member

@stulzq stulzq commented Feb 28, 2022

What this PR does:
add lock in memory
Which issue(s) this PR fixes:

None
Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@stulzq stulzq changed the title feat: add lock in memory feat: add in-memory lock Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #399 (3b493c7) into main (9a7dbef) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   59.83%   60.18%   +0.35%     
==========================================
  Files         116      117       +1     
  Lines        6197     6252      +55     
==========================================
+ Hits         3708     3763      +55     
  Misses       2128     2128              
  Partials      361      361              
Impacted Files Coverage Δ
components/lock/in-memory/in_memory_lock.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7dbef...3b493c7. Read the comment docs.

@stulzq stulzq requested a review from seeflood March 1, 2022 03:52
components/lock/in-memory/in_memory_lock.go Outdated Show resolved Hide resolved
components/lock/in-memory/in_memory_lock.go Outdated Show resolved Hide resolved
@seeflood seeflood assigned seeflood and unassigned wenxuwan Mar 1, 2022
stulzq and others added 3 commits March 1, 2022 21:35
…add_in_memory_lock

# Conflicts:
#	components/lock/in-memory/in_memory_lock.go
seeflood
seeflood previously approved these changes Mar 2, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I added some comments

zhenjunMa
zhenjunMa previously approved these changes Mar 11, 2022
@seeflood seeflood dismissed stale reviews from zhenjunMa and themself via e5615a6 March 11, 2022 04:06
seeflood
seeflood previously approved these changes Mar 11, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I just fixed a bug

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit a386713 into mosn:main Mar 11, 2022
@seeflood
Copy link
Member

This component can make debug easier.Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants