Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add ivr.proto #727

Merged
merged 13 commits into from
Aug 22, 2022
Merged

feat(api): add ivr.proto #727

merged 13 commits into from
Aug 22, 2022

Conversation

seeflood
Copy link
Member

Signed-off-by: seeflood zhou.qunli@foxmail.com

What this PR does:
add ivr.proto

Which issue(s) this PR fixes:

Fixes #726

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Base: 60.61% // Head: 60.61% // No change to project coverage 👍

Coverage data is based on head (348c0cf) compared to base (c116079).
Patch has no changes to coverable lines.

❗ Current head 348c0cf differs from pull request most recent head ad7fc05. Consider uploading reports for the commit ad7fc05 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   60.61%   60.61%           
=======================================
  Files         133      133           
  Lines        8327     8327           
=======================================
  Hits         5047     5047           
  Misses       2704     2704           
  Partials      576      576           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
docs/en/design/notify/ivr.md Outdated Show resolved Hide resolved
docs/en/design/notify/ivr.md Outdated Show resolved Hide resolved
spec/proto/runtime/v1/ivr.proto Outdated Show resolved Hide resolved
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood mentioned this pull request Jul 26, 2022
@ZLBer
Copy link
Member

ZLBer commented Aug 4, 2022

ivr is confusing :-)

@seeflood
Copy link
Member Author

seeflood commented Aug 6, 2022

ivr is confusing :-)

Well, I can change it to PhoneCall

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
Copy link
Member Author

ivr is confusing :-)

@ZLBer fixed. Please review again

Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Copy link
Member

@kevinten10 kevinten10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seeflood seeflood merged commit d1505ce into mosn:main Aug 22, 2022
@seeflood seeflood deleted the ivr_api branch August 22, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: IVR API, or PhoneCall API
5 participants