-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop node 4 support #302
Drop node 4 support #302
Conversation
Should remove from appveyor as well and add 10 to both CIs |
Tests on Node 10 are currently failing due to an issue with lab leak detection. It is fixed in v15 of lab, but upgrading is not an option as they now require Node >= 8.9. I've opened an issue with them backport the fix to the v14 branch. |
This isn't the first time we've bumped up against issues with Lab. Might be time to switch to a test runner with more aligned support goals |
Ava in turn breaks when stubbing |
Bummer. Ya we could try Jest or node-tap. Minimal setup and coverage reporting are really the two big features we're looking for |
Don't really have time at the moment to rewrite the test suite though, so I'll leave that up to you. |
For now maybe consider just disabling the feature of Lab that's causing the problem? (leak detection) Is it needed? I think most test frameworks (like these alternatives) don't have that feature anyways. Still would be nice to use a more reliable test framework when someone has time to do that work. |
Ah like node-tap in #304 |
Closing this in favor of #304 would like to get Windows passing there then can cut a release |
Closes #282.