Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node 4 support #302

Closed
wants to merge 1 commit into from
Closed

Drop node 4 support #302

wants to merge 1 commit into from

Conversation

TheDancingCode
Copy link

Closes #282.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5771dee on TheDancingCode:drop-node4 into 1945a05 on motdotla:master.

@maxbeatty
Copy link
Contributor

Should remove from appveyor as well and add 10 to both CIs

@TheDancingCode
Copy link
Author

Tests on Node 10 are currently failing due to an issue with lab leak detection. It is fixed in v15 of lab, but upgrading is not an option as they now require Node >= 8.9. I've opened an issue with them backport the fix to the v14 branch.

@maxbeatty
Copy link
Contributor

This isn't the first time we've bumped up against issues with Lab. Might be time to switch to a test runner with more aligned support goals

@TheDancingCode
Copy link
Author

Ava in turn breaks when stubbing fs and other internals, which is exactly what happens in these tests. What about Jest?

@maxbeatty
Copy link
Contributor

Bummer. Ya we could try Jest or node-tap. Minimal setup and coverage reporting are really the two big features we're looking for

@TheDancingCode
Copy link
Author

Don't really have time at the moment to rewrite the test suite though, so I'll leave that up to you.

@maxbeatty maxbeatty mentioned this pull request May 2, 2018
3 tasks
@zenflow
Copy link

zenflow commented May 2, 2018

For now maybe consider just disabling the feature of Lab that's causing the problem? (leak detection) Is it needed? I think most test frameworks (like these alternatives) don't have that feature anyways. Still would be nice to use a more reliable test framework when someone has time to do that work.

@zenflow
Copy link

zenflow commented May 2, 2018

Still would be nice to use a more reliable test framework when someone has time to do that work.

Ah like node-tap in #304

@maxbeatty
Copy link
Contributor

Closing this in favor of #304 would like to get Windows passing there then can cut a release

@maxbeatty maxbeatty closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants