-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for Node v4 #304
Conversation
Can anyone with access to a Windows machine take a look at the failing CLI test? Maybe @zenflow since you originally helped add tests for appveyor? |
@maxbeatty Sure, would be a pleasure 👍 I can do this in a couple days |
Hmm. The tests work fine on my local machine..
Let me investigate some more... |
… instead of execSync (#307)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks Max
BREAKING CHANGE closes #282
thanks to rework in #302 switched to node-tap for tests which gives us all the same features in ~30% less LOC
lib/
(regex change was prompted bystandard
)