-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limiting package versions to profile request range #127
Comments
Oo, but I wonder whether we can know which are compatible, without running a full resolve. Since each resolve can take quite some time, it could delay showing that drop-down for many seconds, maybe minutes. What have you got in mind? |
You mean to be able to limit the version range without running full resolve for each combination ? |
If so, I am thinking to jsut pass the version range of profile's package request in Line 380 in a2e48e0
And if that package is not meant to be an application (not weak referenced or is a dependency), skip verison listing. :P |
Say we have this profile :
And the Maya package, maybe like this :
Only Maya will have version |
Got a working draft now ( |
PackagesModel and ApplicationModel are merged into one ResolvedPackagesModel with ApplicationProxyModel and PackagesProxyModel added. Also, model doesn't need controller now.
Resolved with #129. |
Problem
In "Packages" tab, user can change package version with a drop-down list. But the version listed in there is a full list of all installed versions, which can be easily go out side of profile's request range.
E.g. Maya package family has version 2016-2020 installed, but the profile however :
And if you change the version into, say 2018, Maya package resolve would fail.
Proposal
We should avoid exposing those "dead-ends" on interface. Only show versions that are not exceeding profile's requirement.
Also, how about disable those non-application package's version selecting ? I think this could save some compute resource, plus, changing non-application package's version is somewhat not practical.
The text was updated successfully, but these errors were encountered: