From 3ba20cd880bc14a30013891b1f49178802e7ec94 Mon Sep 17 00:00:00 2001 From: Manfred Touron <94029+moul@users.noreply.github.com> Date: Sat, 23 Jul 2022 17:20:19 +0000 Subject: [PATCH] chore: fix go lint Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com> --- internal/dvserver/server.go | 3 ++- internal/githubprovider/model.go | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/dvserver/server.go b/internal/dvserver/server.go index 38a9e78cf..56fb3e40e 100644 --- a/internal/dvserver/server.go +++ b/internal/dvserver/server.go @@ -218,7 +218,8 @@ func New(ctx context.Context, h *cayley.Handle, schema *schema.Config, opts Opts } svc.httpListenerAddr = listener.Addr().String() srv := http.Server{ - Handler: r, + ReadHeaderTimeout: 2 * time.Second, // nolint:gomnd + Handler: r, } svc.workers.Add(func() error { httpLogger.Debug("starting HTTP server", zap.String("bind", opts.HTTPBind)) diff --git a/internal/githubprovider/model.go b/internal/githubprovider/model.go index 814e96f22..714e854f5 100644 --- a/internal/githubprovider/model.go +++ b/internal/githubprovider/model.go @@ -91,7 +91,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error { // assignees for _, assignee := range input.Assignees { - assigneeRet, err := fromUser(batch, assignee) // nolint:typecheck // false-positive? + assigneeRet, err := fromUser(batch, assignee) // nolint:typecheck if err != nil { return fmt.Errorf("from user: %w", err) } @@ -106,7 +106,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error { // labels for _, label := range input.Labels { - labelRet, err := fromLabel(batch, label) // nolint:typecheck // false-positive? + labelRet, err := fromLabel(batch, label) // nolint:typecheck if err != nil { return fmt.Errorf("from label: %w", err) }