Try to make @InjectViewState optional #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2020 08:55
aasitnikov
requested changes
Jan 21, 2020
There was a problem hiding this comment.
Hello! Thanks for your contribution!
I tested the changes in a new project - it really seems like annotation processor can pick up classes, that are not annotated themselves, but have a parent with an annotation. If so, it perfectly applies to Moxy presenters. We evaluated ways to make @InjectViewState optional, but never thought it would be so simple!
Overall changes are good, but could you also add a test, that checks that viewstate is being generated without explicit @InjectViewState on presenter? You can check out ViewTestKt for reference, some check like compilation.generatedSourceFiles().any { it.name.contains("${"$$"}State") } will be sufficient.
aasitnikov
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
@Inheritedannotation to@InjectViewStateand annotate MvpPresenter. It makes all instances ofMvpPresenterannotated.