Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove nice-try #123

Closed
wants to merge 1 commit into from
Closed

refactor: remove nice-try #123

wants to merge 1 commit into from

Conversation

ffflorian
Copy link

This PR will

  • remove nice-try and thus reduce the amount of dependencies

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #123 into master will decrease coverage by 1.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #123     +/-   ##
=========================================
- Coverage   98.88%   97.79%   -1.1%     
=========================================
  Files           7        7             
  Lines         180      181      +1     
  Branches       39       38      -1     
=========================================
- Hits          178      177      -1     
- Misses          2        4      +2
Impacted Files Coverage Δ
lib/parse.js 96.29% <100%> (+0.06%) ⬆️
lib/util/readShebang.js 84.61% <0%> (-15.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bee1d...1c20634. Read the comment docs.

@satazor
Copy link
Contributor

satazor commented Aug 20, 2019

The nice-try dep was removed in #125

@satazor satazor closed this Aug 20, 2019
@ffflorian ffflorian deleted the refactor/nice-try branch August 20, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants