Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Separate content blocking setting from TrackingProtectionState.enabled #9787

Closed
Amejia481 opened this issue Feb 26, 2021 · 0 comments
Closed

Separate content blocking setting from TrackingProtectionState.enabled #9787

Amejia481 opened this issue Feb 26, 2021 · 0 comments
Assignees
@Amejia481
Labels
🐞 bug Something isn't working
Milestone
74.0.0 ⚒

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Feb 26, 2021 •
edited by data-sync-user
Loading

This issue mozilla-mobile/fenix#18101 is caused because we are mixing two concepts, blocking content and tracking protection being enabled, we are updating the state of TrackingProtectionState.enabled based of content blocking being enabled, not on the actual TrackingProtectionPolicy.

  • Blocking content is just one configuration of all available on the TrackingProtectionPolicy.
  • Tracking protection this is a set of configuration that can block different types of trackers depending on how the TrackingProtectionPolicy is configured, one configuration doesn't determine if it's on or off, but desabling all of them at the same time does TrackingProtectionPolicy.none()

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added the 🐞 bug Something isn't working label Feb 26, 2021
@Amejia481 Amejia481 added this to the 74.0.0 milestone Feb 26, 2021
@Amejia481 Amejia481 self-assigned this Feb 26, 2021
Amejia481 added a commit to Amejia481/android-components that referenced this issue Feb 26, 2021
@Amejia481
Closes mozilla-mobile#9787 separate content blocking setting from Tra…
f1476f1 
…ckingProtectionState.enabled
Amejia481 added a commit to Amejia481/android-components that referenced this issue Feb 26, 2021
@Amejia481
Closes mozilla-mobile#9787 close the download stream when dismissing …
1793340 
…the dialog
Amejia481 added a commit to Amejia481/android-components that referenced this issue Mar 1, 2021
@Amejia481
Closes mozilla-mobile#9787 separate content blocking setting from Tra…
9fa795e 
…ckingProtectionState.enabled
Amejia481 added a commit to Amejia481/android-components that referenced this issue Mar 1, 2021
@Amejia481
Closes mozilla-mobile#9787 separate content blocking setting from Tra…
4f3edd8 
…ckingProtectionState.enabled
Amejia481 added a commit to Amejia481/android-components that referenced this issue Mar 2, 2021
@Amejia481
Closes mozilla-mobile#9787 separate content blocking setting from Tra…
aa603ce 
…ckingProtectionState.enabled
@mergify mergify bot closed this as completed in d37bc87 Mar 2, 2021
jonalmeida pushed a commit that referenced this issue Mar 16, 2021
@Amejia481 @jonalmeida
Closes #9787 separate content blocking setting from TrackingProtectio…
6358170 
…nState.enabled
mergify bot pushed a commit that referenced this issue Mar 16, 2021
@Amejia481 @mergify
Closes #9787 separate content blocking setting from TrackingProtectio…
adb7a5e 
…nState.enabled
@Amejia481 Amejia481 mentioned this issue Mar 17, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
74.0.0 ⚒
Development

No branches or pull requests
1 participant
@Amejia481