Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #4299 Add Mechanism to Keep Higher Priority Breadcrumbs if Max… #4426

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Closes #4299 Add Mechanism to Keep Higher Priority Breadcrumbs if Max… #4426

merged 1 commit into from
Sep 18, 2019

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented Sep 16, 2019 •
edited
Loading

… Number of Breadcrumb is recorded

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@rocketsroger rocketsroger requested a review from a team as a code owner September 16, 2019 15:34
@rocketsroger rocketsroger added the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 16, 2019
@rocketsroger
Closes mozilla-mobile#4299 Add Mechanism to Keep Higher Priority Brea…
11166f3 
…dcrumbs if Max Number of Breadcrumb is recorded
@rocketsroger
Copy link
Contributor Author

bors r=pocmo

bors bot pushed a commit that referenced this pull request Sep 17, 2019
@MozLando @rocketsroger
Merge #4426
a3637f6 
4426: Closes #4299 Add Mechanism to Keep Higher Priority Breadcrumbs if Max… r=pocmo a=rocketsroger

… Number of Breadcrumb is recorded




Co-authored-by: Roger Yang <royang@mozilla.com>
@rocketsroger rocketsroger removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 17, 2019
@bors
Copy link

bors bot commented Sep 17, 2019

Timed out

@rocketsroger
Copy link
Contributor Author

bors retry

bors bot pushed a commit that referenced this pull request Sep 18, 2019
@MozLando @rocketsroger @NotWoods
Merge #4426 #4440
5dceae5 
4426: Closes #4299 Add Mechanism to Keep Higher Priority Breadcrumbs if Max… r=pocmo a=rocketsroger

… Number of Breadcrumb is recorded




4440: For #4444: Use AndroidX browser 1.2.0-alpha07 r=rocketsroger a=NotWoods

[How to revert](https://docs.google.com/document/d/1IJBC929ntbTuwX7vJOnlFzqkzI-YL2HueelVQeKRPzA/edit)

This version is needed to support Trusted Web Activities.



Co-authored-by: Roger Yang <royang@mozilla.com>
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
@bors
Copy link

bors bot commented Sep 18, 2019

Build succeeded

@bors bors bot merged commit 11166f3 into mozilla-mobile:master Sep 18, 2019
@rocketsroger rocketsroger added this to the 14.0.0 milestone Sep 18, 2019
@rocketsroger rocketsroger deleted the AC_4299 branch September 18, 2019 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0.0 🔭
Development

Successfully merging this pull request may close these issues.
2 participants
@rocketsroger @pocmo