From 55b86e541f650ca625a31d7d0589c3fc53642c84 Mon Sep 17 00:00:00 2001 From: Grisha Kruglov Date: Mon, 16 Sep 2019 16:33:39 -0700 Subject: [PATCH] Post: address telemetry feedback --- app/metrics.yaml | 13 +------------ app/src/main/res/values/preference_keys.xml | 1 - docs/metrics.md | 6 +++++- 3 files changed, 6 insertions(+), 14 deletions(-) diff --git a/app/metrics.yaml b/app/metrics.yaml index f4ed2ee1b037..d628f9860610 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -863,7 +863,7 @@ sync_auth: other_external: type: event description: > - User signed into FxA via an unknown mechanism + User authenticated via FxA using an unknown mechanism. "Known" mechanisms are currently sign-in, sign-up and pairing bugs: - 4971 data_reviews: @@ -882,17 +882,6 @@ sync_auth: notification_emails: - fenix-core@mozilla.com expires: "2020-03-01" - create_account: - type: event - description: > - A user pressed the create account button on the sync authentication page - bugs: - - 1190 - data_reviews: - - https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532 - notification_emails: - - fenix-core@mozilla.com - expires: "2020-03-01" sync_account: opened: diff --git a/app/src/main/res/values/preference_keys.xml b/app/src/main/res/values/preference_keys.xml index 88731cd26444..a335dd1685b2 100644 --- a/app/src/main/res/values/preference_keys.xml +++ b/app/src/main/res/values/preference_keys.xml @@ -57,7 +57,6 @@ pref_key_cached_account pref_key_sync_pair pref_key_sync_sign_in - pref_key_sync_create_account pref_key_sync_problem project_id pref_key_fxa_signed_in diff --git a/docs/metrics.md b/docs/metrics.md index 095b79241eb7..b62cf1418d55 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -128,12 +128,16 @@ The following metrics are added to the ping: | sync_account.send_tab |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user sent the current tab to another FxA device |[1](https://github.com/mozilla-mobile/fenix/pull/5106)||2020-03-01 | | sync_account.sign_in_to_send_tab |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user pressed the "sign in to send tab" button inside the share tab menu |[1](https://github.com/mozilla-mobile/fenix/pull/5106)||2020-03-01 | | sync_account.sync_now |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user pressed the sync now button on the sync account page |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | +| sync_auth.auto_login |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |User signed into FxA via an account shared from another locally installed Mozilla application (e.g. Fennec) |[1](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)||2020-03-01 | | sync_auth.closed |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user closed the sync page |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | -| sync_auth.create_account |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user pressed the create account button on the sync authentication page |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | | sync_auth.opened |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user opened the sync authentication page |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | +| sync_auth.other_external |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |User authenticated via FxA using an unknown mechanism. "Known" mechanisms are currently sign-in, sign-up and pairing |[1](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)||2020-03-01 | +| sync_auth.paired |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |User signed into FxA by pairing with a different Firefox browser, using a QR code |[1](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)||2020-03-01 | +| sync_auth.recovered |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |Account manager automatically recovered FxA authentication state without direct user involvement |[1](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)||2020-03-01 | | sync_auth.scan_pairing |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user pressed the scan pairing button on the sync authentication page |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | | sync_auth.sign_in |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user pressed the sign in button on the sync authentication page and was successfully signed in to FxA |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | | sync_auth.sign_out |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |A user pressed the sign out button on the sync account page and was successfully signed out of FxA |[1](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)||2020-03-01 | +| sync_auth.sign_up |[event](https://mozilla.github.io/glean/book/user/metrics/event.html) |User registered a new Firefox Account, and was signed into it |[1](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)||2020-03-01 | ## metrics This is a built-in ping that is assembled out of the box by the Glean SDK.