From ad4e03ac0d02a0bdb69a4800e1b8d5ca5d55e64d Mon Sep 17 00:00:00 2001 From: mcarare Date: Tue, 8 Dec 2020 13:14:48 +0200 Subject: [PATCH] For #16827: Add copy url from long press metrics. --- .../main/java/org/mozilla/fenix/components/metrics/Event.kt | 2 ++ .../mozilla/fenix/components/metrics/GleanMetricsService.kt | 3 +++ .../main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt | 2 ++ 3 files changed, 7 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt index ed988beae42d..65b9fa7acdc0 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt @@ -187,6 +187,8 @@ sealed class Event { object TabSettingsOpened : Event() + object CopyUrlUsed : Event() + object SyncedTabOpened : Event() object RecentlyClosedTabsOpened : Event() diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index 9d0aa8fd9ef8..a3b56e81e0c8 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -673,6 +673,9 @@ private val Event.wrapper: EventWrapper<*>? { ProgressiveWebApp.background.record(it) }, { ProgressiveWebApp.backgroundKeys.valueOf(it) } ) + is Event.CopyUrlUsed -> EventWrapper( + { Events.copyUrlTapped.record(it) } + ) is Event.SyncedTabOpened -> EventWrapper( { Events.syncedTabOpened.record(it) } diff --git a/app/src/main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt b/app/src/main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt index af5f9169cfd5..21c56576b772 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt @@ -20,6 +20,7 @@ import mozilla.components.browser.state.selector.selectedTab import mozilla.components.browser.state.store.BrowserStore import org.mozilla.fenix.R import org.mozilla.fenix.components.FenixSnackbar +import org.mozilla.fenix.components.metrics.Event import org.mozilla.fenix.ext.components import java.lang.ref.WeakReference @@ -74,6 +75,7 @@ object ToolbarPopupWindow { .setText(context.getString(R.string.browser_toolbar_url_copied_to_clipboard_snackbar)) .show() } + context.components.analytics.metrics.track(Event.CopyUrlUsed) } customView.paste.setOnClickListener {