explicitly wait for buttons to become visible, to avoid slow animations

functions/tsconfig.json

@@ -6,7 +6,8 @@
     "outDir": "lib",
     "sourceMap": true,
     "strict": true,
-    "target": "es2017"
+    "target": "es2017",
+    "typeRoots": [ "node_modules/@types" ]
   },
   "compileOnSave": true,
   "include": [

package.json

@@ -27,6 +27,7 @@
     "@rollup/plugin-replace": "^2.4.1",
     "@sveltejs/adapter-static": "^1.0.0-next.14",
     "@sveltejs/kit": "1.0.0-next.141",
+    "@types/eslint": "^7.28.0",
     "@types/jest": "^27.0.1",
     "@types/selenium-webdriver": "^4.0.15",
     "babel-core": "^7.0.0-bridge.0",

tests/integration/ux.test.ts

@@ -77,22 +77,23 @@ describe("Rally Web Platform extension interop", function () {
     // Start to join study, but cancel.
     await findAndAct(this.driver, By.xpath('//button[text()="Join Study"]'), e => e.click());
     await findAndAct(this.driver, By.xpath('//button[text()="Cancel"]'), e => e.click());
-    await this.driver.wait(until.elementLocated(By.xpath('//button[text()="Join Study"]')), WAIT_FOR_PROPERTY);
+    await this.driver.wait(until.elementIsVisible(await this.driver.findElement(By.xpath('//button[text()="Join Study"]'))), WAIT_FOR_PROPERTY);
 
     // Start to join study, and confirm.
     await findAndAct(this.driver, By.xpath('//button[text()="Join Study"]'), e => e.click());
     await findAndAct(this.driver, By.xpath('//button[text()="Accept & Enroll"]'), e => e.click());
-    await this.driver.wait(until.elementLocated(By.xpath('//button[text()="Leave Study"]')), WAIT_FOR_PROPERTY);
+    await this.driver.wait(until.elementIsVisible(await this.driver.findElement(By.xpath('//button[text()="Leave Study"]'))), WAIT_FOR_PROPERTY);
 
     // Start to leave study, but cancel.
     await findAndAct(this.driver, By.xpath('//button[text()="Leave Study"]'), e => e.click());
     await findAndAct(this.driver, By.xpath('//button[text()="Cancel"]'), e => e.click());
-    await this.driver.wait(until.elementLocated(By.xpath('//button[text()="Leave Study"]')), WAIT_FOR_PROPERTY);
+    await this.driver.wait(until.elementIsVisible(await this.driver.findElement(By.xpath('//button[text()="Leave Study"]'))), WAIT_FOR_PROPERTY);
 
     // Start to leave study, and confirm.
     await findAndAct(this.driver, By.xpath('//button[text()="Leave Study"]'), e => e.click());
     await findAndAct(this.driver, By.xpath('(//button[text()="Leave Study"])[2]'), e => e.click());
-    await this.driver.wait(until.elementLocated(By.xpath('//button[text()="Join Study"]')), WAIT_FOR_PROPERTY);
+    await this.driver.wait(until.elementIsVisible(await this.driver.findElement(By.xpath('//button[text()="Join Study"]'))), WAIT_FOR_PROPERTY);
+
 
     // TODO make sure in-page link works
     await this.driver.get("http://localhost:5000/profile");