This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Lint before deploy #113
Merged
Lint before deploy #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamilton
approved these changes
Sep 2, 2021
Carla-Moz
pushed a commit
to Carla-Moz/rally-web-platform
that referenced
this pull request
Sep 3, 2021
* remove google eslint rules * Lint failures can cause deploy to fail, make sure we lint during the build and test phase * only run functions lint, link to issue about fixing other linters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint failures in cloud functions can cause deploy to fail, so make sure we lint during the build and test phase.
I noticed that our top-level
npm run lintis failing (we need to make changes to makeprettierandeslinthappy), I filed #112 to track that.