Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

remove errant vim tmpfile and add to gitignore #147

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Sep 22, 2021

No description provided.

@rhelmer rhelmer requested a review from Carla-Moz September 22, 2021 21:23
@rhelmer rhelmer self-assigned this Sep 22, 2021
@rhelmer
Copy link
Contributor Author

rhelmer commented Sep 23, 2021

The test failure here isn't related to the patch, pretty sure it's due to Chrome 94 being release yesterday:

SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 92
    Current browser version is 94.0.4606.54 with binary path /usr/bin/google-chrome

Chromedriver is used by Selenium and installed by npm, I'll make sure everything there is up-to-date.

@rhelmer rhelmer force-pushed the ignore-vim-tmpfiles branch from 4620ddc to ad9b390 Compare September 23, 2021 00:40
Copy link
Contributor

@Carla-Moz Carla-Moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good on my end.

@rhelmer rhelmer merged commit f707be7 into mozilla-rally:master Sep 23, 2021
@rhelmer rhelmer deleted the ignore-vim-tmpfiles branch September 27, 2021 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants