Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Account management new #205

Merged
merged 5 commits into from
Feb 10, 2022
Merged

Account management new #205

merged 5 commits into from
Feb 10, 2022

Conversation

Carla-Moz
Copy link
Contributor

@Carla-Moz Carla-Moz commented Feb 8, 2022

This is a hefty PR and I apologize in advance. I promise future PRs won't be so large.

Major changes include the following:

  1. Centered container for all pages
  2. Navbar and footer with routes to pages and external links
  3. Sign-out functionality in drop-down of navbar
  4. New account management styles which will probably change so let's keep as placeholder for now
  5. Added Sass to the platform; there are still some lingering in line styles that need cleaning up as the sass files evolve. Might also be some repeating styles which I'll clean in next PR.
  6. Not responsive yet; that's for the next PR.

@Carla-Moz Carla-Moz requested review from rhelmer and stansky February 8, 2022 05:03
@Carla-Moz Carla-Moz self-assigned this Feb 8, 2022
Copy link
Contributor

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, I didn't focus on the style changes too much (except verifying that it looks and works ok visually), just a few minor things I noticed.

firebase.config.json Outdated Show resolved Hide resolved
src/app.html Outdated Show resolved Hide resolved
src/lib/components/auth-cards/LaunchCard.svelte Outdated Show resolved Hide resolved
src/lib/views/account-settings/UpdatePassword.svelte Outdated Show resolved Hide resolved
src/routes/_Sidebar.svelte Outdated Show resolved Hide resolved
src/routes/__layout.svelte Outdated Show resolved Hide resolved
src/routes/account-settings/index.svelte Outdated Show resolved Hide resolved
src/routes/profile/index.svelte Outdated Show resolved Hide resolved
@Carla-Moz Carla-Moz requested a review from rhelmer February 9, 2022 15:22
@Carla-Moz Carla-Moz merged commit ebf3569 into master Feb 10, 2022
@Carla-Moz Carla-Moz deleted the account-management-new branch February 10, 2022 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants