Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Sync facebook-pixel-hunt data with latest from study-remote-settings #250

Merged

Conversation

@rhelmer rhelmer requested review from stansky and Carla-Moz March 10, 2022 19:20
@rhelmer rhelmer self-assigned this Mar 10, 2022
@rhelmer
Copy link
Contributor Author

rhelmer commented Mar 10, 2022

After this is deployed, we need to call this cloud function which will cause it to load into /studies in firestore:

export const loadFirestore = functions.https.onRequest(
async (request, response) => {
for (const [index, study] of Object.entries(studies)) {
console.info(`Loading study ${index} into Firestore`);
addRallyStudyToFirestore(index, study);
}
response.status(200).send();
}
);

@rhelmer rhelmer removed request for stansky and Carla-Moz March 11, 2022 17:31
@rhelmer
Copy link
Contributor Author

rhelmer commented Mar 12, 2022

I copied things into Firestore to see what it looks like, I think we need to change the way quote marks are encoded, but it seems ok otherwise on stage:

image

@rhelmer rhelmer force-pushed the add-facebook-pixel-hunt-extensions branch from d4a3e5e to 4905e15 Compare May 11, 2022 16:18
@rhelmer rhelmer force-pushed the add-facebook-pixel-hunt-extensions branch from 4905e15 to 2f78777 Compare May 11, 2022 16:23
@rhelmer rhelmer requested review from thomik-corp and aaga May 11, 2022 17:07
Copy link
Contributor

@aaga aaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It offends my modular sensibilities but sometimes you gotta do what you gotta do; looks good to me!

@rhelmer rhelmer merged commit bc0c381 into mozilla-rally:master May 11, 2022
@rhelmer rhelmer deleted the add-facebook-pixel-hunt-extensions branch May 11, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants