Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Integration tests for Rally Web Platform #79

Merged
merged 68 commits into from
Aug 25, 2021

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Aug 21, 2021

This PR sets up the Firebase emulators, and allows writing jest+typescript tests using Selenium.

It also updates the README with info on how testing works, and how you can use the Firebase emulators for local development (which I definitely recommend, it's quite easy!)

Currently it supports Firefox and signs in (using the emulated Google auth handler) and tests the UX for the site both with and without an extension installed.

I'd like to add a few things before landing:

  • add Chrome support
  • add screenshot on CI failure
  • dump browser/webextension and server logs so we can inspect for correct behavior

However I think it's good enough to review now.

@rhelmer rhelmer closed this Aug 21, 2021
@rhelmer rhelmer reopened this Aug 21, 2021
@rhelmer rhelmer requested review from hamilton and Carla-Moz August 21, 2021 10:19
@rhelmer rhelmer self-assigned this Aug 21, 2021
Copy link
Contributor

@hamilton hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I appreciate that we're only using replace in the initialize-firestore module, since we're least likely to be utilizing that when pulling in Storybook.

Had a few small suggestions. Feel free to merge this once those are taken care of.

scripts/add-demo-studies-to-firebase.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com>
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Carla-Moz Carla-Moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the emulator working. It's so cool! Also just had one comment about adding the path to the README re the file we have to update locally.

@rhelmer rhelmer requested a review from Carla-Moz August 25, 2021 16:35
@rhelmer rhelmer merged commit a8ba9d3 into mozilla-rally:master Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants