This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Integration tests for Rally Web Platform #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhelmer
force-pushed
the
integration-test
branch
from
August 21, 2021 10:30
b00fc95
to
38bce40
Compare
This was referenced Aug 24, 2021
hamilton
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I appreciate that we're only using replace in the initialize-firestore
module, since we're least likely to be utilizing that when pulling in Storybook.
Had a few small suggestions. Feel free to merge this once those are taken care of.
Co-authored-by: Hamilton Ulmer <hamilton.ulmer@gmail.com>
Carla-Moz
reviewed
Aug 25, 2021
Carla-Moz
suggested changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the emulator working. It's so cool! Also just had one comment about adding the path to the README re the file we have to update locally.
Carla-Moz
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the Firebase emulators, and allows writing jest+typescript tests using Selenium.
It also updates the README with info on how testing works, and how you can use the Firebase emulators for local development (which I definitely recommend, it's quite easy!)
Currently it supports Firefox and signs in (using the emulated Google auth handler) and tests the UX for the site both with and without an extension installed.
I'd like to add a few things before landing:
However I think it's good enough to review now.