Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Show google account chooser #94

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Aug 25, 2021

Also fixes the broken google sign-in image. Fixes issue #71.

@rhelmer rhelmer requested a review from Carla-Moz August 25, 2021 20:51
@rhelmer rhelmer self-assigned this Aug 25, 2021
@rhelmer
Copy link
Contributor Author

rhelmer commented Aug 25, 2021

image

@rhelmer
Copy link
Contributor Author

rhelmer commented Aug 25, 2021

We can't test this using the emulator since this requires the real google sign-in service and not the emulated one (the emulated one always uses this behavior FWIW)

Copy link
Contributor

@Carla-Moz Carla-Moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@Carla-Moz
Copy link
Contributor

Looks good! Thanks

No changes requested. Had hit the wrong button.

@rhelmer rhelmer merged commit 7b740b5 into mozilla-rally:master Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants