Skip to content

Commit

Permalink
Remove seemingly-unnecessary urldecoding. (#2906)
Browse files Browse the repository at this point in the history
I added this a Very Long Time Ago in adb45b6. I don't see anything in there that suggests it was needed, nor do any tests fail if it is removed. There's no data in this field that _should_ be urlencoded, and even if there was, decoding is already handled by Flask/Werkzeug...so we should be able to safely remove this.
  • Loading branch information
bhearsum authored Jul 5, 2023
1 parent fdeb9f7 commit 036d4a9
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/auslib/web/public/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@
from auslib.services import releases
from auslib.web.public.helpers import AUS, get_aus_metadata_headers, get_content_signature_headers, with_transaction

try:
from urllib import unquote
except ImportError: # pragma: no cover
from urllib.parse import unquote


LOG = logging.getLogger(__name__)


Expand Down Expand Up @@ -110,7 +104,6 @@ def getQueryFromURL(url):
if "systemCapabilities" in query:
query.update(getSystemCapabilities(url["systemCapabilities"]))
del query["systemCapabilities"]
query["osVersion"] = unquote(query["osVersion"])
ua = request.headers.get("User-Agent")
query["headerArchitecture"] = getHeaderArchitecture(query["buildTarget"], ua)
force = query.get("force")
Expand Down

0 comments on commit 036d4a9

Please sign in to comment.