Merge pull request #1077 from mozilla-services/feat/1076

bug: Update APNs APS block
mozilla-services · Nov 14, 2017 · 7289761 · 7289761
2 parents 1c2e227 + b8b52e8
commit 7289761
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/autopush/router/apnsrouter.py b/autopush/router/apnsrouter.py
@@ -137,7 +137,10 @@ def _route(self, notification, router_data):
                 payload["enckey"] = notification.headers["encryption_key"]
             payload['aps'] = router_data.get('aps', {
                 "mutable-content": 1,
-                "alert": {"title": " ", "body": " "}
+                "alert": {
+                    "loc-key": "SentTab.NoTabArrivingNotification.body",
+                    "title-loc-key": "SentTab.NoTabArrivingNotification.title",
+                }
             })
         apns_id = str(uuid.uuid4()).lower()
         # APNs may force close a connection on us without warning.

diff --git a/autopush/tests/test_integration.py b/autopush/tests/test_integration.py
@@ -1938,8 +1938,10 @@ def test_registration(self):
         assert ca_data['cryptokey'] == crypto_key
         assert ca_data['enc'] == salt
         assert 'mutable-content' in ca_data['aps']
-        assert ca_data['aps']['alert']['title'] == " "
-        assert ca_data['aps']['alert']['body'] == " "
+        assert ca_data["aps"]["alert"]["loc-key"] == \
+            "SentTab.NoTabArrivingNotification.body"
+        assert ca_data["aps"]["alert"]["title-loc-key"] == \
+            "SentTab.NoTabArrivingNotification.title"
         assert ca_data['body'] == base64url_encode(data)
 
     @inlineCallbacks

diff --git a/autopush/tests/test_router.py b/autopush/tests/test_router.py
@@ -182,7 +182,10 @@ def test_route_notification(self):
             "ver": 10,
             "aps": {
                 "mutable-content": 1,
-                "alert": {"title": " ", "body": " "}
+                "alert": {
+                    "loc-key": "SentTab.NoTabArrivingNotification.body",
+                    "title-loc-key": "SentTab.NoTabArrivingNotification.title",
+                },
             },
             "enckey": "test",
             "con": "aesgcm",