Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix ctrl-c not working under autopush_rs #1090

Closed
pjenvey opened this issue Nov 30, 2017 · 1 comment · Fixed by #1131
Closed

fix ctrl-c not working under autopush_rs #1090

pjenvey opened this issue Nov 30, 2017 · 1 comment · Fixed by #1131
Assignees
@pjenvey
Labels
bug
Milestone
2018Q1-1.1 Rust c...

Comments

@pjenvey
Copy link
Member

pjenvey commented Nov 30, 2017

Currently autopush_rs doesn't correctly handle SIGINT to quit the process. Ideally it would be joining on all the worker threads -- but thread join blocks signal handling.

We may need to make a busy loop in the main python thread to handle receiving the signal and triggering shutdown -- not ideal but I'm not sure there's another option. I think Python 3 may have some improvements for this situation
@pjenvey pjenvey added the bug label Nov 30, 2017
@bbangert bbangert mentioned this issue Nov 30, 2017
Closed
9 tasks
@bbangert
Copy link
Member

Note that this will also need to update the sentry code to track the thread handle and join it on shutdown as well.

@pjenvey pjenvey added the ready label Dec 6, 2017
@bbangert bbangert mentioned this issue Jan 19, 2018
Closed
10 tasks
@pjenvey pjenvey self-assigned this Feb 5, 2018
pjenvey added a commit that referenced this issue Feb 13, 2018
@pjenvey
fix: make autopush_rs's ctrl-c work gracefully
909f1d1 
also fix pulling SENTRY_DSN from runtime vs build env

Closes #1090
pjenvey added a commit that referenced this issue Feb 13, 2018
@pjenvey
fix: make autopush_rs's ctrl-c work gracefully
37fd773 
also fix pulling SENTRY_DSN from build vs runtime env

Closes #1090
pjenvey added a commit that referenced this issue Feb 13, 2018
@pjenvey
fix: make autopush_rs's ctrl-c work gracefully
038be38 
also include the rust sentry thread in the shutdown process and fix
pulling SENTRY_DSN from build vs runtime env

Closes #1090
pjenvey added a commit that referenced this issue Feb 13, 2018
@pjenvey
fix: make autopush_rs's ctrl-c work gracefully
bdbd4ad 
also include the rust sentry thread in the shutdown process and fix
pulling SENTRY_DSN from build vs runtime env

Closes #1090
@pjenvey pjenvey mentioned this issue Feb 13, 2018
Merged
@pjenvey pjenvey added in progress and removed ready labels Feb 13, 2018
pjenvey added a commit that referenced this issue Feb 13, 2018
@pjenvey
fix: make autopush_rs's ctrl-c work gracefully
624de2d 
also include the rust sentry thread in the shutdown process and fix
pulling SENTRY_DSN from build vs runtime env

Closes #1090
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug
Projects
None yet
Milestone
2018Q1-1.1 Rust connection nodes work...
Development

Successfully merging a pull request may close this issue.

fix: make autopush_rs's ctrl-c work gracefully mozilla-services/autopush
2 participants
@pjenvey @bbangert