Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

filled in sentry tracebacks appear in wrong order #1134

Closed
pjenvey opened this issue Feb 13, 2018 · 0 comments
Closed

filled in sentry tracebacks appear in wrong order #1134

pjenvey opened this issue Feb 13, 2018 · 0 comments
Assignees
@pjenvey
Labels
bug
Milestone
E3.2 Sentry produ...

Comments

@pjenvey
Copy link
Member

pjenvey commented Feb 13, 2018

When our logger fills in a stack trace (due to one not present #613) the order of the stack trace is wrong, despite our use of raven's iter_stack_frames. Sentry expects "Frames should be sorted from oldest to newest." https://docs.sentry.io/clientdev/interfaces/stacktrace/

iter_stack_frames goes by python's typical inspect.stack order, in the reverse
@pjenvey pjenvey added the bug label Feb 13, 2018
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Feb 13, 2018
@pjenvey pjenvey self-assigned this Feb 13, 2018
pjenvey added a commit that referenced this issue Feb 13, 2018
@pjenvey
fix: reverse our filled in stack trace order
73338ac 
frames should be sorted from oldest to newest despite raven's
iter_stack_frames

Closes #1134
This was referenced Feb 13, 2018
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug
Projects
None yet
Milestone
E3.2 Sentry production exceptions are...
Development

No branches or pull requests
2 participants
@pjenvey @jrconlin