Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Handle boto3 "InternalServerError" #1138

Closed
pjenvey opened this issue Feb 26, 2018 · 0 comments
Closed

Handle boto3 "InternalServerError" #1138

pjenvey opened this issue Feb 26, 2018 · 0 comments
Assignees
Labels

Comments

@pjenvey
Copy link
Member

pjenvey commented Feb 26, 2018

From sentry:

https://sentry.prod.mozaws.net/operations/autopush-prod/issues/2696847/
https://sentry.prod.mozaws.net/operations/autopush-prod/issues/2710042/
https://sentry.prod.mozaws.net/operations/autopush-prod/issues/2872776/

These botocore.errorfactory.InternalServerError look analogous to the generic boto2 BotoServerError we still handle -- generally triggered when the number of retries exceeded max

@pjenvey pjenvey self-assigned this Feb 26, 2018
pjenvey added a commit that referenced this issue Mar 1, 2018
by treating ClientError as we originally treated boto2's
JSONResponseError

centralize endpoint's ClientError handling into _boto_err (kills
_overload_err as it's all now handled in one place)

Issue #1138
pjenvey added a commit that referenced this issue Mar 2, 2018
it was previously handling only the old boto2 JSONResponseError in
those spots

also kill the remaining boto2 bits

Closes #1138
pjenvey added a commit that referenced this issue Mar 2, 2018
it was previously handling only the old boto2 JSONResponseError in
those spots

also kill the remaining boto2 bits

Closes #1138
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants