Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Reject padded Base64 in crypto headers #451

Closed
ghost opened this issue Apr 21, 2016 · 0 comments
Closed

Reject padded Base64 in crypto headers #451

ghost opened this issue Apr 21, 2016 · 0 comments
Assignees

Comments

@ghost
Copy link

ghost commented Apr 21, 2016

@martinthomson suggested rejecting padded params in https://bugzilla.mozilla.org/show_bug.cgi?id=1256488#c8, and draft-ietf-httpbis-encryption-encoding cites RFC 7515, too.

Unfortunately, the test page used the padded form for a while, and I suspect others might, too. These senders will break once bug 1256488 lands.

I think we should detect these on the server and return a more helpful error, instead of having the client fail decryption.

+@jrconlin

@ghost ghost added the enhancement label Apr 21, 2016
@ghost ghost added this to the PUSHSVC-0: quality milestone Apr 21, 2016
jrconlin added a commit that referenced this issue Apr 21, 2016
The client will soon reject any key content that includes padding.
The server will need to watch and strip it. We should also return a
warning message, however the likelihood of that warning being noticed
is minimal.

Closes #451
@jrconlin jrconlin self-assigned this Apr 21, 2016
jrconlin added a commit that referenced this issue Apr 22, 2016
The client will soon reject any key content that includes padding.
The server will need to watch and strip it. We should also return a
warning message, however the likelihood of that warning being noticed
is minimal.

Closes #451
jrconlin added a commit that referenced this issue Apr 28, 2016
The client will soon reject any key content that includes padding.
The server will need to watch and strip it. We should also return a
warning message, however the likelihood of that warning being noticed
is minimal.

Closes #451
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants