Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Remove or consolidate datadog user agent tag #487

Closed
oremj opened this issue Jun 21, 2016 · 0 comments
Closed

Remove or consolidate datadog user agent tag #487

oremj opened this issue Jun 21, 2016 · 0 comments
Assignees
@bbangert
Labels
in progress Operational p1
Milestone
PUSHSVC-0: quality

Comments

@oremj
Copy link
Contributor

oremj commented Jun 21, 2016 •
edited by bbangert
Loading

Right now we are setting a user agent tag on most datadog metrics. This consumes a lot of datadog resources. Let's either remove that tag completely or reduce them in to a known set e.g., BROWSER-VERSION-OS. That alone should reduce the set from thousands to (# of versions) * (# of OSs).
@bbangert bbangert added the ready label Jul 19, 2016
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Jul 19, 2016
@bbangert bbangert self-assigned this Jul 20, 2016
bbangert added a commit that referenced this issue Jul 26, 2016
@bbangert
feat: normalize user-agent for datadog and parse for raw logging
8f54300 
The user-agent string is now parsed and normalized to fewer values for DataDog. The
raw parsed version is also included in all websocket.py logging statements for easier
filtering in our logging. Existing raw user_agent string will remain so that existing log
parsing systems using it can function as normal.

Closes #487
@bbangert bbangert mentioned this issue Jul 26, 2016
Merged
bbangert added a commit that referenced this issue Jul 26, 2016
@bbangert
feat: normalize user-agent for datadog and parse for raw logging
0a89fe5 
The user-agent string is now parsed and normalized to fewer values for DataDog. The
raw parsed version is also included in all websocket.py logging statements for easier
filtering in our logging. Existing raw user_agent string will remain so that existing log
parsing systems using it can function as normal.

Closes #487
bbangert added a commit that referenced this issue Jul 26, 2016
@bbangert
feat: normalize user-agent for datadog and parse for raw logging
985598d 
The user-agent string is now parsed and normalized to fewer values for DataDog. The
raw parsed version is also included in all websocket.py logging statements for easier
filtering in our logging. Existing raw user_agent string will remain so that existing log
parsing systems using it can function as normal.

Closes #487
bbangert added a commit that referenced this issue Jul 26, 2016
@bbangert
feat: normalize user-agent for datadog and parse for raw logging
8c4c636 
The user-agent string is now parsed and normalized to fewer values for DataDog. The
raw parsed version is also included in all websocket.py logging statements for easier
filtering in our logging. Existing raw user_agent string will remain so that existing log
parsing systems using it can function as normal.

Closes #487
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
in progress Operational p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@oremj @bbangert