This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Verify valid webpush record before considering it an existing user #523
Comments
bbangert
added a commit
that referenced
this issue
Jul 15, 2016
When a client says hello, the register user method now performs a router lookup to verify the record actually exists and has the appropriate necessary attributes. A check is also done for webpush users to verify the server still has a table object it can use to pull notifications for during verification so the uaid can be reset if needed. This cleans up the hello handling, removing the need for a separate hello finish and simplifying the callbacks. Closes #523
bbangert
added a commit
that referenced
this issue
Jul 15, 2016
When a client says hello, the register user method now performs a router lookup to verify the record actually exists and has the appropriate necessary attributes. A check is also done for webpush users to verify the server still has a table object it can use to pull notifications for during verification so the uaid can be reset if needed. This cleans up the hello handling, removing the need for a separate hello finish and simplifying the callbacks. Closes #523
jrconlin
pushed a commit
that referenced
this issue
Jul 16, 2016
When a client says hello, the register user method now performs a router lookup to verify the record actually exists and has the appropriate necessary attributes. A check is also done for webpush users to verify the server still has a table object it can use to pull notifications for during verification so the uaid can be reset if needed. This cleans up the hello handling, removing the need for a separate hello finish and simplifying the callbacks. Closes #523
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now we just check to see if the UUID seems right for 'existing user'. We should instead do a router record read, and verify it has required attributes set before continuing.
One of the attributes we should check is that the current_month for the route record is in self.ps.settings.message_tables, and consider it an invalid record if not. This would let us remove the block of buggy code at https://github.com/mozilla-services/autopush/blob/1.15.1/autopush/websocket.py#L783 which fails to actually create a new record with the returned UAID.
The text was updated successfully, but these errors were encountered: