Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Time multiple parts of endpoint request processing #758

Closed
bbangert opened this issue Dec 9, 2016 · 0 comments
Closed

Time multiple parts of endpoint request processing #758

bbangert opened this issue Dec 9, 2016 · 0 comments
Assignees
@bbangert
Labels
p1
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

bbangert commented Dec 9, 2016 •
edited
Loading

To track performance issues, we should not just record the complete routing time, but break it down as a histogram and record the time taken for individual parts of the request, ie:

  • Request validation
  • Database lookups
  • Routing completion

All of these times should be included in the final log message, and if an error occurs, we should ensure we still log the timings with that error handler.
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Dec 9, 2016
@bbangert bbangert self-assigned this Dec 13, 2016
@bbangert bbangert added p1 and removed p2 labels Dec 13, 2016
bbangert added a commit that referenced this issue Dec 23, 2016
@bbangert
feat: Add request timing w/validation breakdown.
6e619a7 
Add's full request timing with validation and routing break-outs. Also logs the request
and validation timing even if validation fails or routing otherwise errors out.

Closes #758
@bbangert bbangert mentioned this issue Dec 23, 2016
Merged
bbangert added a commit that referenced this issue Dec 31, 2016
@bbangert
feat: Add request timing w/validation breakdown.
c460b92 
Add's full request timing with validation and routing break-outs. Also logs the request
and validation timing even if validation fails or routing otherwise errors out.

Closes #758
bbangert added a commit that referenced this issue Jan 4, 2017
@bbangert
feat: Add request timing w/validation breakdown.
c065737 
Add's full request timing with validation and routing break-outs. Also logs the request
and validation timing even if validation fails or routing otherwise errors out.

Closes #758
bbangert added a commit that referenced this issue Jan 4, 2017
@bbangert
feat: Add request timing w/validation breakdown.
d386936 
Add's full request timing with validation and routing break-outs. Also logs the request
and validation timing even if validation fails or routing otherwise errors out.

Closes #758
bbangert added a commit that referenced this issue Jan 4, 2017
@bbangert
feat: Add request timing w/validation breakdown.
b2a491c 
Add's full request timing with validation and routing break-outs. Also logs the request
and validation timing even if validation fails or routing otherwise errors out.

Closes #758
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@pjenvey @bbangert