Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Use consistent log field names and avoid mixing types #882

Closed
bbangert opened this issue Apr 26, 2017 · 1 comment
Closed

Use consistent log field names and avoid mixing types #882

bbangert opened this issue Apr 26, 2017 · 1 comment
Assignees
Labels

Comments

@bbangert
Copy link
Member

For logging, if its the same info, it should have the same field name everywhere. Otherwise it's easy to exclude it from our parquet files accidentally. I have no strong opinion on which name is used in any of these cases, but they need a consistent name.

Here are the ones I've identified thus far:

For mixed types, we use an empty string when no status or logged_status is present which can mess up analysis. We should use a known 'null' value like 0 instead of "" when logging numbers and want to log a lack of one.

@bbangert bbangert added this to the 2017Q2-4.1 Uptime Dashboard milestone Apr 26, 2017
@bbangert bbangert self-assigned this Apr 27, 2017
bbangert added a commit that referenced this issue Apr 27, 2017
Adds a unified parquet stream for all log messages with a message
matcher for necessary endpoint and connection node messages.
Logging fields were cleaned up for consistency and status code
logging uses a 0 instead of "" to avoid mixing types.

Closes #874, #882
bbangert added a commit that referenced this issue Apr 27, 2017
Adds a unified parquet stream for all log messages with a message
matcher for necessary endpoint and connection node messages.
Logging fields were cleaned up for consistency and status code
logging uses a 0 instead of "" to avoid mixing types.

Closes #874, #882
bbangert added a commit that referenced this issue Apr 27, 2017
Adds a unified parquet stream for all log messages with a message
matcher for necessary endpoint and connection node messages.
Logging fields were cleaned up for consistency and status code
logging uses a 0 instead of "" to avoid mixing types.

Closes #874, #882
bbangert added a commit that referenced this issue Apr 27, 2017
Adds a unified parquet stream for all log messages with a message
matcher for necessary endpoint and connection node messages.
Logging fields were cleaned up for consistency and status code
logging uses a 0 instead of "" to avoid mixing types.

Closes #874, #882
bbangert added a commit that referenced this issue Apr 27, 2017
Adds a unified parquet stream for all log messages with a message
matcher for necessary endpoint and connection node messages.
Logging fields were cleaned up for consistency and status code
logging uses a 0 instead of "" to avoid mixing types.

Closes #874, #882
@bbangert
Copy link
Member Author

Closed by #883.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant