This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: add logging for register/unregister calls for websocket and bridges #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
force-pushed
the
bug/952
branch
2 times, most recently
from
d6e66ad to
9120782
Compare
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 57 57
Lines 9608 9616 +8
=====================================
+ Hits 9608 9616 +8
Continue to review full report at Codecov.
|
jrconlin
added a commit
that referenced
this pull request
Jul 11, 2017
pjenvey
reviewed
Jul 11, 2017
| chid=str(dummy_chid)), | ||
| headers={"Authorization": self.auth}, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Should really check for a resp.get_status() is 200 afterwards
pjenvey
approved these changes
Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #952