This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: upgrade rust deps to latest #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update openssl and hyper usage per their new deprecations Issue #1104
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 59 59
Lines 9833 9833
=======================================
Hits 9803 9803
Misses 30 30Continue to review full report at Codecov.
|
alexcrichton
approved these changes
Jan 27, 2018
jrconlin
approved these changes
Jan 29, 2018
| let push_srv = push_listener.incoming().for_each(move |(socket, addr)| { | ||
| proto.bind_connection(&handle, socket, addr, ::http::Push(srv.clone())); | ||
| let http = Http::<hyper::Chunk>::new(); | ||
| let push_srv = push_listener.incoming().for_each(move |(socket, _)| { |
There was a problem hiding this comment.
I take it this defaults to addr '0.0.0.0'?
There was a problem hiding this comment.
Above it binds to the addr derived from router_ip/port (AutopushConfig's router_hostname). I'm not sure that's quite right actually
bbangert
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update openssl and hyper usage per their new deprecations
Issue #1104