Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: handle InternalServerErrors (ClientError subclass) #1140

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Mar 2, 2018

by treating ClientError as we originally treated boto2's
JSONResponseError

centralize endpoint's ClientError handling into _boto_err (kills
_overload_err as it's all now handled in one place)

Issue #1138

by treating ClientError as we originally treated boto2's
JSONResponseError

centralize endpoint's ClientError handling into _boto_err (kills
_overload_err as it's all now handled in one place)

Issue #1138
@codecov-io
Copy link

codecov-io commented Mar 2, 2018

Codecov Report

Merging #1140 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%     
==========================================
  Files          60       60              
  Lines        9965     9966       +1     
==========================================
+ Hits         9942     9943       +1     
  Misses         23       23
Impacted Files Coverage Δ
autopush/websocket.py 100% <ø> (ø) ⬆️
autopush/tests/test_web_base.py 100% <100%> (ø) ⬆️
autopush/web/base.py 100% <100%> (ø) ⬆️
autopush/tests/test_websocket.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a678007...62cbc40. Read the comment docs.

@jrconlin jrconlin merged commit dd2af26 into master Mar 2, 2018
@bbangert bbangert deleted the fix/1138 branch March 2, 2018 02:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants